Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit max entries shown in MSFS 2020 preset combo box #1810

Merged
merged 4 commits into from
Aug 11, 2024

Conversation

Koseng
Copy link
Contributor

@Koseng Koseng commented Aug 4, 2024

fixes #1809

This change leads to instant loading. Also it probably does not make sense to scroll a list of more than 1500 entries.

Max number changed to 1500.

loadAllItems

Copy link

github-actions bot commented Aug 4, 2024

Build for this pull request:
MobiFlightConnector.zip

Copy link

github-actions bot commented Aug 6, 2024

Build for this pull request:
MobiFlightConnector.zip

@Koseng Koseng changed the title DRAFT: Limit max entries shown in MSFS 2020 preset combo box Limit max entries shown in MSFS 2020 preset combo box Aug 6, 2024
@Koseng Koseng marked this pull request as ready for review August 6, 2024 16:30
@Koseng Koseng requested a review from DocMoebiuz as a code owner August 6, 2024 16:30
UI/Panels/Config/HubHopPresetPanel.cs Show resolved Hide resolved
UI/Panels/Config/HubHopPresetPanel.cs Outdated Show resolved Hide resolved
ProjectMessages/ProjectMessages.de.resx Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Aug 8, 2024

Build for this pull request:
MobiFlightConnector.zip

@JaimeLeon2
Copy link

I don't expect I will ever use the "list all events" option. However, I think having to scroll 1,500 entries to get to this option is too long for any interested user.

Copy link

github-actions bot commented Aug 8, 2024

Build for this pull request:
MobiFlightConnector.zip

@Koseng
Copy link
Contributor Author

Koseng commented Aug 8, 2024

I don't expect I will ever use the "list all events" option. However, I think having to scroll 1,500 entries to get to this option is too long for any interested user.

Discussion is continued in discord.

@DocMoebiuz DocMoebiuz merged commit 752e707 into MobiFlight:main Aug 11, 2024
1 check passed
@DocMoebiuz DocMoebiuz added the enhancement Improvement of an existing feature label Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Annoying long loading time of MSFS 2020 presets dialog
3 participants